[Grappler] Fix bug in UpdateSqueezeDims #41399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The dim logic in generic_layout_transposer's SqueezeTransposer was
incorrect, which caused two problems:
- Negative dims were transformed incorrectly.
- The dim check incorrectly failed when dim = rank - 1 (which can
occur when transforming NCHW to NHWC).
- Fixes the dim logic and adds tests to check these cases.
rmlarsen
approved these changes
Jul 22, 2020
google-ml-butler
bot
added
kokoro:force-run
|
@benbarsdell thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dim logic in generic_layout_transposer's SqueezeTransposer was incorrect, which caused two problems:
This PR fixes the dim logic and adds tests to check these cases.
cc @nluehr