Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 writable and appendable #41477

Merged
merged 3 commits into from
Jul 17, 2020
Merged

S3 writable and appendable #41477

merged 3 commits into from
Jul 17, 2020

Conversation

vnghia
Copy link
Contributor

@vnghia vnghia commented Jul 17, 2020

@mihaimaruseac
This PR adds tf_writable_file, NewWritableFile and NewAppendableFile.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jul 17, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 17, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 17, 2020
@vnghia
Copy link
Contributor Author

vnghia commented Jul 17, 2020

Internal import failed. Is there any way that I can access the result or run some tests locally to make sure my PR pass the internal import ?

@gbaned gbaned self-assigned this Jul 17, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jul 17, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 17, 2020
@vnghia
Copy link
Contributor Author

vnghia commented Jul 17, 2020

It failed again :(

@mihaimaruseac
Copy link
Collaborator

I'll import manually, sorry for the delay.

@tensorflow-copybara tensorflow-copybara merged commit fdf1095 into tensorflow:master Jul 17, 2020
PR Queue automation moved this from Assigned Reviewer to Merged Jul 17, 2020
@vnghia vnghia deleted the s3-appendable branch July 17, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vnghia @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned