S3 read only memory region and stat #41511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaimaruseac
approved these changes
Jul 17, 2020
google-ml-butler
bot
added
kokoro:force-run
|
I am not sure why it didn't work before. It's very likely that it is because the import happens at file level (so if a file changed, you need to rebase back on master), unlike git which is at change level |
|
@mihaimaruseac |
|
Will import manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mihaimaruseac
This PR adds
tf_read_only_memory_region,NewReadOnlyMemoryRegionFromFileandStat( because we needGetFileSize).Thank you for doing an import manually with the previous PR.
Could you please tell me why the it failed the internal import ?