Refactor gcs part 2 random access file #41592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaimaruseac
approved these changes
Jul 21, 2020
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mihaimaruseac
This PR add
stat_cacheforNewRandomAccessFileandLoadBufferFromGCS. It also fixes some problems related toTF_OUT_OF_RANGEbecause thecoreimplementation does not considerTF_OUT_OF_RANGEas an error.Now we have to wait for the next release of
google-cloud-cpp. That release will contain the features needed for compose mode ofNewAppendableFileand some gcs filesystem ops (Stat,GetChildren)In the mean time, I will send you some PRs to add tests ported from
coreimplementation.