-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doe tensorflow has api similar to pytorch's “masked_fill_” #41617
Comments
Can you please go through tf.boolean_mask and see this is the feature you are looking for? |
No,it's different. tensorflow:
pytorch:
|
Got it.Thanks! |
@gowthamkpr Hi, I would like to work in this. Can anyone help with how and from where I can start ? |
@gowthamkp Should we have to add a new api or we can also override boolean_mask with one more parameter, which one will be better? |
Strawman proposal. Can this be implemented as def masked_fill(t, mask, value): Might have to do some dtype handling but roughly should work? What are the performance requirements for this? |
@ravikyram @gowthamkpr please review this PR #41975 |
tf.where([True, False, True],5,[1,2,3]) |
We recommend the tf.where implementation. |
pytorch has squeeze , tf also has squeeze.
pytorch has unsqueeze, tf has expand_dims do the same thing with diff name.
pythorh has masked_fill , tf has ?
Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information
Describe the feature and the current behavior/state.
masked_fill_ api doc in pytorch
Will this change the current api? How?
Maybe not. It will add a new api.
Who will benefit with this feature?
someone try to migrate from pytorch to tensorflow like me.
Any Other info.
The text was updated successfully, but these errors were encountered: