Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 delete file delete/create dir #41622

Merged

Conversation

vnghia
Copy link
Contributor

@vnghia vnghia commented Jul 22, 2020

@mihaimaruseac
This PR adds delete/create dir and delete file for s3.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jul 22, 2020
@gbaned gbaned self-assigned this Jul 22, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 22, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 22, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 22, 2020
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 23, 2020
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Jul 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 23, 2020
@mihaimaruseac
Copy link
Collaborator

@shivaylamba Respectfully, I'd ask to refrain from approving PRs when the PR was already approved and the review you submitted has no power to trigger the CI/merge (as you are not an owner of the code / in the organisation). Note the grayed checkmark:
pr

Your review in this case blocked CI and there was a need for another review to unblock. Please don't approve random PRs on GitHub.

@tensorflow-copybara tensorflow-copybara merged commit a6ba8c1 into tensorflow:master Jul 23, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 23, 2020
@vnghia vnghia deleted the s3-delete-file-delete-create-dir branch July 23, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants