Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect mapping in fast tensor <=> np mapping #41677

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Fix incorrect mapping in fast tensor <=> np mapping #41677

merged 1 commit into from
Jul 25, 2020

Conversation

yongtang
Copy link
Member

This PR fixes the incorrect mapping in fast tensor <=> np mapping
See diff below:

       dtypes.qint16.as_numpy_dtype:
-          fast_tensor_util.AppendInt8ArrayToTensorProto,
+          fast_tensor_util.AppendInt16ArrayToTensorProto,
       dtypes.quint16.as_numpy_dtype:
-          fast_tensor_util.AppendUInt8ArrayToTensorProto,
+          fast_tensor_util.AppendUInt16ArrayToTensorProto,

This PR is part of the effort to pass PR #41421's internal test.

Signed-off-by: Yong Tang yong.tang.github@outlook.com

@yongtang
Fix incorrect mapping in fast tensor <=> np mapping
f5d98d0 
This PR fixes the incorrect mapping in fast tensor <=> np mapping
See diff below:
```diff
       dtypes.qint16.as_numpy_dtype:
-          fast_tensor_util.AppendInt8ArrayToTensorProto,
+          fast_tensor_util.AppendInt16ArrayToTensorProto,
       dtypes.quint16.as_numpy_dtype:
-          fast_tensor_util.AppendUInt8ArrayToTensorProto,
+          fast_tensor_util.AppendUInt16ArrayToTensorProto,
```

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 23, 2020
@yongtang yongtang mentioned this pull request Jul 23, 2020
Merged
@gbaned gbaned self-assigned this Jul 24, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 24, 2020
mihaimaruseac
mihaimaruseac approved these changes Jul 24, 2020
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 24, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 24, 2020
@tensorflow-copybara tensorflow-copybara merged commit 0770aec into tensorflow:master Jul 25, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 25, 2020
@yongtang yongtang deleted the 26069-fill-qint8-qint16-prerequisite branch July 25, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yongtang @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned