Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the usage of uninitialized variable in adaptive_shared_batch_scheduler #41745

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Fix the usage of uninitialized variable in adaptive_shared_batch_scheduler #41745

merged 1 commit into from
Jul 29, 2020

Conversation

kitstar
Copy link
Contributor

@kitstar kitstar commented Jul 26, 2020

The variable best_score is uninitialized.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 26, 2020
@gbaned gbaned self-assigned this Jul 26, 2020
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Jul 26, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 26, 2020
@gbaned gbaned requested a review from jaingaurav July 26, 2020 15:53
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 27, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 27, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 27, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jul 28, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 28, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 28, 2020
@tensorflow-copybara tensorflow-copybara merged commit ec16354 into tensorflow:master Jul 29, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 29, 2020
tensorflow-copybara pushed a commit that referenced this pull request Jul 29, 2020
@tensorflower-gardener
PR #41745: Fix the usage of uninitialized variable in adaptive_shared…
5ed1a8f 
…_batch_scheduler

Imported from GitHub PR #41745

The variable best_score is uninitialized.
Copybara import of the project:

--
68f9891 by Cheng CHEN <chencheng.kit@bytedance.com>:

Fix the usage of uninitialized variable.

PiperOrigin-RevId: 323776083
Change-Id: I06abbc952059c804c19379d928bfdbd529b73233
@kitstar kitstar mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaingaurav jaingaurav jaingaurav approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:core issues related to core part of tensorflow ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kitstar @jaingaurav @gbaned @googlebot @kokoro-team @tensorflow-copybara