Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the batch sizes with 'None' instead '?' #41747

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

V2dha
Copy link
Contributor

@V2dha V2dha commented Jul 26, 2020

I have replaced the default text to be shown if batch sizes are not present as 'None' instead of '?' because it is more readable and understandable during the plotting of the model. Furthermore, it avoids the confusion of any error in the model and signifies that the fact that the programmer voluntarily haven't given any batch sizes

I have replaced the default text to be shown if batch sizes are not present as 'None' instead of '?' because it is more readable and understandable during the plotting of the model. Furthermore, it avoids the confusion of any error in the model and signifies that the fact that the programmer voluntarily haven't given any batch sizes
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 26, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@V2dha
Copy link
Contributor Author

V2dha commented Jul 26, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gbaned gbaned self-assigned this Jul 27, 2020
@gbaned gbaned added the comp:keras Keras related issues label Jul 27, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 27, 2020
@gbaned gbaned requested a review from qlzh727 July 27, 2020 03:43
@gbaned gbaned added the awaiting review Pull request awaiting review label Jul 29, 2020
@qlzh727
Copy link
Member

qlzh727 commented Aug 3, 2020

Thanks for the PR.

I think the "None" is a more standard way in python to express unassigned/unknown value. Do u have any specific example that "None" is causing any confusion?

@V2dha
Copy link
Contributor Author

V2dha commented Aug 3, 2020

Thanks for the PR.

I think the "None" is a more standard way in python to express unassigned/unknown value. Do u have any specific example that "None" is causing any confusion?

There might be some confusion my pull request actually replaces the "?" question mark with "None" because in the vis_utils.py original file the default is "?" question mark which somehows signifies error rather than a missing value.

"None" specifies that voluntarily I have not specified values. But the default parameter in the keras vis_utils file is "?" question mark. Therefore I made a pull request where I have replaced the "?" question mark with "None". As you stated "None" is a more standard way in python to express unassigned/unknown value rather than a question mark.

Original tensorflow code

Right now the default is "?" question mark if value is not specified. I changed it to "None" therefore I made a pull request. It is much easier to understand.

For instance look at the figures below :
model with ?

To change the above image with "None" I have to locally go to the tensorflow library installed in my computer and then change the vis_utils.py line from "?" to "None" to get the following result.

model with "None"

So I think it would be easy if the default parameter for non-specified values is "None" instead of a "?" question mark that's why in this pull request I have replaced the "?" question mark with "None" in the vis_utils.py file.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 4, 2020
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for the detailed reply.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 4, 2020
@gbaned gbaned removed the awaiting review Pull request awaiting review label Aug 4, 2020
@tensorflow-copybara tensorflow-copybara merged commit 34bb002 into tensorflow:master Aug 4, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 4, 2020
@V2dha V2dha deleted the V2dha-patch-1 branch November 15, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants