Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wsign-compare] warning resolutions, by directory, 4 #41751

Conversation

tg-at-google
Copy link
Contributor

Resolution affecting directories:
tensorflow/compiler/tf2xla

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jul 26, 2020
@tg-at-google
Copy link
Contributor Author

@mihaimaruseac

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unrelated changes

tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/rearrange_function_argument.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/xla_compiler.cc Outdated Show resolved Hide resolved
@tg-at-google
Copy link
Contributor Author

updates applied.

tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/rearrange_function_argument.cc Outdated Show resolved Hide resolved
@tg-at-google
Copy link
Contributor Author

recommended updates applied.

tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/functionalize_cond.cc Outdated Show resolved Hide resolved
tg-at-google and others added 3 commits July 29, 2020 15:35
Co-authored-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Co-authored-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Co-authored-by: Mihai Maruseac <mihai.maruseac@gmail.com>
@tg-at-google
Copy link
Contributor Author

updates applied, 3.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 29, 2020
@tensorflow-copybara tensorflow-copybara merged commit a647794 into tensorflow:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants