-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm][XLA] Fixing no_alias_test #41782
Merged
tensorflow-copybara
merged 1 commit into
tensorflow:master
from
ROCm:zyin-xla-noalias_test
Aug 7, 2020
Merged
[ROCm][XLA] Fixing no_alias_test #41782
tensorflow-copybara
merged 1 commit into
tensorflow:master
from
ROCm:zyin-xla-noalias_test
Aug 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timshen91
requested changes
Aug 3, 2020
@jerryyin Can you please check @timshen91's comments and keep us posted ? Thanks! |
jerryyin
force-pushed
the
zyin-xla-noalias_test
branch
from
August 5, 2020 17:46
3655a49
to
b55bb7f
Compare
@gbaned Resolve and rebased in the latest commit. Thanks. |
timshen91
approved these changes
Aug 6, 2020
google-ml-butler
bot
added
kokoro:force-run
Tests on submitted change
ready to pull
PR ready for merge process
labels
Aug 6, 2020
gbaned
added
ready to pull
PR ready for merge process
and removed
ready to pull
PR ready for merge process
labels
Aug 7, 2020
gbaned
approved these changes
Aug 7, 2020
google-ml-butler
bot
added
kokoro:force-run
Tests on submitted change
ready to pull
PR ready for merge process
labels
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update file-check statement to match with function signature. Same as #35572.
/cc @deven-amd