Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm][XLA] Fixing no_alias_test #41782

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

jerryyin
Copy link
Member

Update file-check statement to match with function signature. Same as #35572.

/cc @deven-amd

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jul 27, 2020
@gbaned gbaned self-assigned this Jul 28, 2020
@gbaned gbaned added the comp:xla XLA label Jul 28, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 28, 2020
@gbaned gbaned added the awaiting review Pull request awaiting review label Jul 29, 2020
@gbaned gbaned requested a review from timshen91 August 3, 2020 17:21
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Aug 3, 2020
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Aug 5, 2020
@gbaned
Copy link
Contributor

gbaned commented Aug 5, 2020

@jerryyin Can you please check @timshen91's comments and keep us posted ? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Aug 5, 2020
@jerryyin
Copy link
Member Author

jerryyin commented Aug 5, 2020

@gbaned Resolve and rebased in the latest commit. Thanks.

@gbaned gbaned requested a review from timshen91 August 6, 2020 11:17
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label Aug 6, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 6, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 6, 2020
@kokoro-team kokoro-team removed kokoro:force-run Tests on submitted change labels Aug 6, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 7, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 7, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 7, 2020
@tensorflow-copybara tensorflow-copybara merged commit f3fad99 into tensorflow:master Aug 7, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:xla XLA ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants