Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment for protobuf compilation #41889

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Fix environment for protobuf compilation #41889

merged 1 commit into from
Jul 31, 2020

Conversation

Flamefire
Copy link
Contributor

The invocation environment for protobuf compilation is ignoring environment variables like LD_LIBRARY_PATH which were used when building protoc. This leads to failures due to e.g. mismatches in the libstdc++.so versions.

This fixes #41857 by using the patch from upstream grpc/grpc#23664

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jul 30, 2020
@gbaned gbaned self-assigned this Jul 30, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 30, 2020
@Flamefire Flamefire mentioned this pull request Jul 30, 2020
Closed
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 30, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 30, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 30, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jul 31, 2020
@tensorflow-copybara tensorflow-copybara merged commit 23d1fc1 into tensorflow:master Jul 31, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 31, 2020
@Flamefire Flamefire deleted the fix_protoc_build branch July 31, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

protoc fails to execute due to missing environment (LD_LIBRARY_PATH)
6 participants
@Flamefire @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned