Fix the usage of uninitialized variable in adaptive_shared_batch_scheduler and windows build error. #42032
Conversation
| @@ -425,7 +425,7 @@ void AdaptiveSharedBatchScheduler<TaskType>::MaybeScheduleNextBatch() { | |||
| return; | |||
| } | |||
| auto best_it = batches_.end(); | |||
| double best_score; | |||
| double best_score = (std::numeric_limits<double>::max)(); | |||
There was a problem hiding this comment.
Why are the parenthesis around max needed? I thought the problem with the old PR was simply the missing parenthesis at the end.
There was a problem hiding this comment.
Why are the parenthesis around
maxneeded? I thought the problem with the old PR was simply the missing parenthesis at the end.
Ref the discussion on MSDN and stackoverflow,
"The <Windows.h> header file that includes macro definitions named max and min:
#define max(a,b) (((a) > (b)) ? (a) : (b))
The preprocessor replaces the max identifier in the expression:
std::numeric_limits<size_t>::max() to std::numeric_limits<size_t>::(((a) > (b)) ? (a) : (b))
Wrap the call to max with parenthesis, which prevents the macro expansion.
" by Piotr Skotnicki
|
@kitstar Can you please check @jaingaurav's comments and keep us posted ? Thanks! |
google-ml-butler
bot
added
kokoro:force-run
Same as #41745 #41745
The variable best_score is uninitialized, but the old PR was reverted because it broke Windows Build.
The new PR fixs the build problem.