Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-TRT op converter test variable naming #42044

Merged
merged 1 commit into from Aug 27, 2020
Merged

TF-TRT op converter test variable naming #42044

merged 1 commit into from Aug 27, 2020

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Aug 4, 2020 •
edited

This PR fixes the naming convention of the ParameterizedOpConverterTestBase member variables. The issue was raised here: #39990 (comment)

Tagging @bixia1 for review. Tagging @MattConley for visibility.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Aug 4, 2020
@gbaned gbaned self-assigned this Aug 5, 2020
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Aug 5, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 5, 2020
@gbaned gbaned requested a review from bixia1 August 5, 2020 05:07
@gbaned
Copy link
Contributor

gbaned commented Aug 11, 2020

@tfeher Can you please resolve conflicts? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Aug 11, 2020
bixia1
bixia1 reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@bixia1 bixia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update your workspace, the previous PR is already merged. There is a typo in the PR description "fixis".

@gbaned
Copy link
Contributor

gbaned commented Aug 18, 2020

@tfeher Can you please check @bixia1's comments and resolve conflicts?. Thanks!

@tfeher
Copy link
Contributor Author

tfeher commented Aug 19, 2020

Thanks for the patience, I have updated the PR.

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Aug 21, 2020
@gbaned gbaned requested a review from bixia1 August 21, 2020 18:14
@gbaned gbaned added the awaiting review Pull request awaiting review label Aug 21, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 26, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 26, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 26, 2020
@gbaned gbaned removed the awaiting review Pull request awaiting review label Aug 27, 2020
@tensorflow-copybara tensorflow-copybara merged commit ecc6730 into tensorflow:master Aug 27, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bixia1 bixia1 bixia1 approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels
cla: yes comp:gpu:tensorrt Issues specific to TensorRT ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tfeher @gbaned @bixia1 @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara