Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /hip suffix to find hip path #42095

Merged
merged 1 commit into from
Aug 6, 2020
Merged

add /hip suffix to find hip path #42095

merged 1 commit into from
Aug 6, 2020

Conversation

acxz
Copy link
Contributor

@acxz acxz commented Aug 6, 2020

Resolves #42081
Fix courtesy of @Imajie

This PR helps move along the build when building tensorflow from source.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Aug 6, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@acxz
Copy link
Contributor Author

acxz commented Aug 6, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Aug 6, 2020
@gbaned gbaned self-assigned this Aug 6, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 6, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 6, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 6, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 6, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 6, 2020
@tensorflow-copybara tensorflow-copybara merged commit d62ab3a into tensorflow:master Aug 6, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 6, 2020
@acxz acxz deleted the fix-hip-path branch August 6, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

[ROCm] Cannot find rocm library hip_hcc
6 participants