Utilize TensorFormat #42102
Merged
Utilize TensorFormat #42102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WindQAQ
force-pushed
the
utilize-tensor-format
branch
from
f05f278
to
e29b09b
Compare
|
/cc @smit-hinsu for visibility. |
smit-hinsu
approved these changes
Aug 6, 2020
| @@ -339,15 +339,18 @@ void BatchToSpaceOp::getCanonicalizationPatterns( | |||
| // are not unknown. | |||
| // | |||
| static LogicalResult Verify(BiasAddOp op) { | |||
| StringRef format = op.data_format(); | |||
| if (format == "NHWC") { | |||
| std::string data_format = op.data_format().str(); | |||
There was a problem hiding this comment.
optional nit: To avoid materializing the string here for FormatFromString, let's change input type of the function to be string_view. Then, we can convert from StringRef to string_view directly.
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.