[TF:MLIR] Improve parallelism of tf.AddN #42135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @smit-hinsu for visibility. |
jpienaar
reviewed
Aug 7, 2020
| }; | ||
|
|
||
| // Accumulate range `[begin, half)` and `[half, end)`, | ||
| // and add the results of two halves. |
There was a problem hiding this comment.
Why two halves vs a tree of additions? (meaning this is an improvement but if the goal is additional parallelism one could go further)
There was a problem hiding this comment.
Sounds good! I change it to tree-based reduction. Please check it out 😃
smit-hinsu
reviewed
Aug 7, 2020
| // | | | | | | ||
| // ------- ------- | | ||
| // | | | | ||
| // 1 5 | |
smit-hinsu
previously approved these changes
Aug 8, 2020
| int64_t j = 0; | ||
| for (int64_t i = 0; i < n; i += 2, ++j) { | ||
| // Add two adjacent operands if applicable. | ||
| operands[j] = (i + 1 < n) |
There was a problem hiding this comment.
nit: we can use operands[i/2] and n = (n+1)/2.
google-ml-butler
bot
added
kokoro:force-run
Clarify range
Fix comment Update index Remove trivial word Use only i to index
smit-hinsu
approved these changes
Aug 8, 2020
google-ml-butler
bot
added
kokoro:force-run
jpienaar
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.