Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TF_ForwardInputOrAllocateOutput to Kernel C API #42194

Merged
merged 4 commits into from
Aug 20, 2020
Merged

Added TF_ForwardInputOrAllocateOutput to Kernel C API #42194

merged 4 commits into from
Aug 20, 2020

Conversation

dnguyen28061
Copy link
Contributor

Extended C API with OpKernel method. Also added tests to test input forwarding.

@annarev @bmzhao

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Aug 10, 2020
@annarev annarev requested review from annarev and bmzhao August 10, 2020 23:40
bmzhao
bmzhao previously approved these changes Aug 11, 2020
View reviewed changes
tensorflow/c/kernels_test.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels.h Outdated Show resolved Hide resolved
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 11, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 11, 2020
bmzhao
bmzhao previously approved these changes Aug 11, 2020
View reviewed changes
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 11, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Aug 12, 2020
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 12, 2020
annarev
annarev reviewed Aug 12, 2020
View reviewed changes
tensorflow/c/kernels.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels_test.cc Outdated Show resolved Hide resolved
@gbaned gbaned removed their assignment Aug 13, 2020
@dnguyen28061 dnguyen28061 force-pushed the forward_input_or_allocate_output branch from dd124e2 to aa88605 Compare August 13, 2020 15:22
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Aug 13, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 13, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 13, 2020
annarev
annarev previously approved these changes Aug 13, 2020
View reviewed changes
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Aug 13, 2020
@google-ml-butler google-ml-butler bot added the ready to pull PR ready for merge process label Aug 13, 2020
@annarev annarev added the API review API Review label Aug 13, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Aug 13, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 13, 2020
@annarev annarev requested a review from alextp August 14, 2020 20:49
annarev
annarev previously approved these changes Aug 14, 2020
View reviewed changes
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 14, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 19, 2020
annarev
annarev reviewed Aug 19, 2020
View reviewed changes
tensorflow/c/kernels_test.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels_test.cc Show resolved Hide resolved
@dnguyen28061 dnguyen28061 force-pushed the forward_input_or_allocate_output branch from dd7d5c3 to 1925149 Compare August 19, 2020 21:46
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Aug 19, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 19, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 19, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 19, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 19, 2020
@tensorflow-copybara tensorflow-copybara merged commit 66603e9 into tensorflow:master Aug 20, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annarev annarev annarev approved these changes

@bmzhao bmzhao bmzhao left review comments

@alextp alextp Awaiting requested review from alextp

Assignees
No one assigned
Labels
API review API Review cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dnguyen28061 @bmzhao @annarev @googlebot @kokoro-team @tensorflow-copybara @rthadur @gbaned