Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF:MLIR] Canonicalize ShapeNOp with partial static input shape #42195

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Aug 10, 2020

Canonicalize ShapeNOp by replacing corresponding output with static input shape.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Aug 10, 2020
@WindQAQ
Copy link
Member Author

WindQAQ commented Aug 10, 2020

/cc @smit-hinsu for visibility.

Copy link
Contributor

@smit-hinsu smit-hinsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!

tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc Outdated Show resolved Hide resolved
tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc Outdated Show resolved Hide resolved
tensorflow/compiler/mlir/tensorflow/ir/tf_ops_n_z.cc Outdated Show resolved Hide resolved
@WindQAQ WindQAQ changed the title [TF:MLIR] Canonicalize ShapeNOp with partial input shape [TF:MLIR] Canonicalize ShapeNOp with partial static input shape Aug 10, 2020
@WindQAQ WindQAQ force-pushed the canonicalize-shape-n-with-partial-static-input-shape branch 2 times, most recently from 7fabc6f to 17c76b5 Compare August 10, 2020 22:10
Use getType directly

Create ShapeOp instead of ShapeNOp when there is only one dynamic input

Run clang-format

Use plural variable name
Remove folder

Add tests

Use getElementTypeOrSelf utility
@WindQAQ WindQAQ force-pushed the canonicalize-shape-n-with-partial-static-input-shape branch from 17c76b5 to b9c5f80 Compare August 10, 2020 22:49
Copy link
Contributor

@smit-hinsu smit-hinsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good tests!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 11, 2020
@gbaned gbaned self-assigned this Aug 11, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 11, 2020
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 11, 2020
@tensorflow-copybara tensorflow-copybara merged commit 6974852 into tensorflow:master Aug 11, 2020
PR Queue automation moved this from Assigned Reviewer to Merged Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants