-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TF:MLIR] Canonicalize ShapeNOp with partial static input shape #42195
Merged
tensorflow-copybara
merged 3 commits into
tensorflow:master
from
WindQAQ:canonicalize-shape-n-with-partial-static-input-shape
Aug 11, 2020
Merged
[TF:MLIR] Canonicalize ShapeNOp with partial static input shape #42195
tensorflow-copybara
merged 3 commits into
tensorflow:master
from
WindQAQ:canonicalize-shape-n-with-partial-static-input-shape
Aug 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cc @smit-hinsu for visibility. |
smit-hinsu
requested changes
Aug 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions!
WindQAQ
changed the title
[TF:MLIR] Canonicalize ShapeNOp with partial input shape
[TF:MLIR] Canonicalize ShapeNOp with partial static input shape
Aug 10, 2020
WindQAQ
force-pushed
the
canonicalize-shape-n-with-partial-static-input-shape
branch
2 times, most recently
from
August 10, 2020 22:10
7fabc6f
to
17c76b5
Compare
smit-hinsu
requested changes
Aug 10, 2020
smit-hinsu
requested changes
Aug 10, 2020
Simplify variable
Use getType directly Create ShapeOp instead of ShapeNOp when there is only one dynamic input Run clang-format Use plural variable name
Remove folder Add tests Use getElementTypeOrSelf utility
WindQAQ
force-pushed
the
canonicalize-shape-n-with-partial-static-input-shape
branch
from
August 10, 2020 22:49
17c76b5
to
b9c5f80
Compare
smit-hinsu
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good tests!
google-ml-butler
bot
added
kokoro:force-run
Tests on submitted change
ready to pull
PR ready for merge process
labels
Aug 11, 2020
rthadur
added
ready to pull
PR ready for merge process
and removed
ready to pull
PR ready for merge process
labels
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonicalize ShapeNOp by replacing corresponding output with static input shape.