Use nasmlink genrule #42266
Merged
Use nasmlink genrule #42266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids cyclic dependency as the name and src must not be the same
perfinion
approved these changes
Aug 21, 2020
rthadur
approved these changes
Aug 21, 2020
gbaned
added
ready to pull
jaimergp
added a commit
to goanpeca/staged-recipes
that referenced
this pull request
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids cyclic dependency as the name and src must not be the same. This uses the same mechanism as done by cython
Fixes #42264 (see that for more details), TLDR is:
Currently the build file sets the name and src to "nasm" which is forbidden: https://docs.bazel.build/versions/master/be/shell.html
This PR fixes that by using an intermediate rule with a different name