Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eager tensor concat #42269

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Fix eager tensor concat #42269

merged 1 commit into from
Aug 13, 2020

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Aug 12, 2020

Fixes #42254.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Aug 12, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Aug 12, 2020
@rthadur rthadur requested a review from edloper August 12, 2020 16:41
@rthadur rthadur added the comp:ops OPs related issues label Aug 12, 2020
@edloper
Copy link
Contributor

edloper commented Aug 12, 2020

Could you please add a test that fails without this change and passes with it?

@WindQAQ
Copy link
Member Author

WindQAQ commented Aug 12, 2020

Could you please add a test that fails without this change and passes with it?

Hi @edloper, this is an issue with keras symbolic tensor, can I use keras as dependencies in tensorflow/python/kernel_tests/* (seems that all kernel_tests do not depend on keras), or is there any way to emulate symbolic tensor?

@edloper
Copy link
Contributor

edloper commented Aug 12, 2020

@WindQAQ Ah ok, yeah, that's kind of tricky to add a test for. I guess it's ok as long as you verified that this fixes the failing Keras case.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 12, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 12, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 12, 2020
@tensorflow-copybara tensorflow-copybara merged commit fb3bf46 into tensorflow:master Aug 13, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edloper edloper edloper approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:ops OPs related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tf.signal.stft throws RuntimeException when pad_end=True
7 participants
@WindQAQ @edloper @googlebot @kokoro-team @tensorflow-copybara @rthadur @gbaned