Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF:MLIR] Verify and fold tf.Tile #42326

Merged
merged 4 commits into from
Aug 28, 2020
Merged

[TF:MLIR] Verify and fold tf.Tile #42326

merged 4 commits into from
Aug 28, 2020

Conversation

WindQAQ
Copy link
Member

@WindQAQ WindQAQ commented Aug 13, 2020

Verify and fold tf.Tile.

@WindQAQ
Verify and fold tf.Tile
ac40eee 
Fold when both input and multiples are constant

Fix tests

Do not fold when input is constant

Empty line

Fix typo
@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Aug 13, 2020
@gbaned gbaned self-assigned this Aug 13, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 13, 2020
@gbaned gbaned requested a review from jpienaar August 13, 2020 17:10
jpienaar
jpienaar previously approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@jpienaar jpienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 14, 2020
@rthadur
Copy link
Contributor

rthadur commented Aug 14, 2020

@WindQAQ can you please resolve conflicts , thank you

PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Aug 14, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 14, 2020
@WindQAQ WindQAQ requested a review from jpienaar August 14, 2020 22:29
rthadur
rthadur previously approved these changes Aug 14, 2020
View reviewed changes
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 14, 2020
@gbaned
Copy link
Contributor

gbaned commented Aug 15, 2020

@WindQAQ Can you please resolve conflicts? Thanks!

@gbaned gbaned removed the ready to pull PR ready for merge process label Aug 15, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Aug 15, 2020
@WindQAQ WindQAQ requested a review from rthadur August 15, 2020 06:12
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 15, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 15, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 17, 2020
@tensorflow-copybara tensorflow-copybara merged commit ccd2fff into tensorflow:master Aug 28, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rthadur rthadur rthadur approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

@jpienaar jpienaar Awaiting requested review from jpienaar

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@WindQAQ @rthadur @gbaned @jpienaar @googlebot @kokoro-team @tensorflow-copybara