[tflite] Make --nnapi_accelerator_name work in kernel tests #42400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freedomtan
force-pushed
the
make_nnapi_accelerator_name_work
branch
from
cd2ccf8
to
abdd0e2
Compare
tensorflow/lite/kernels/test_main.cc
Outdated
| delegate_providers->MutableParams()->Set<std::string>( | ||
| "nnapi_accelerator_name", "nnapi-reference"); | ||
| opt_name, accelerator_name.empty() ? "nnapi-reference" |
There was a problem hiding this comment.
Might simply overwrite the parameter value if --nnapi_accelerator_name is not set?, i.e.
auto* params = delegate_providers->MutableParams();
if (!params->HasValueSetstd::string("nnapi_accelerator_name")) {
params->Setstd::string("nnapi_accelerator_name", "nnapi-reference");
}
There was a problem hiding this comment.
looks like same logic, I didn't notice there is HasValueSet(). Updated. Thanks.
multiverse-tf
approved these changes
Aug 17, 2020
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, when
--nnapi=true, always testnnapi-reference, the NNAPI CPU reference implementation. Now when--nnapi_accelerator_nameis specified, set it as is.@multiverse-tf: my colleagues and me want to use these kernel tests to test NNAPI drivers other than
nnapi-reference.