Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTEL MKL] Enable NCHW to NHWC conversion for CPU - part1 #42448

Conversation

mdfaijul
Copy link
Contributor

This is an already reviewed PR #39760 with a fix to GPU failure.

This PR enables layout (data format) conversion from NCHW to NHWC on CPU. This is useful (1) when a model is trained on GPU and later doing inference/fine-tuning on CPU and (2) helps quantizing NCHW trained model for CPU.

To make the PR small, we have included a few unit tests in this part1. More unit tests will follow on future PRs.

@mdfaijul
Copy link
Contributor Author

mdfaijul commented Aug 18, 2020

@gbaned @ezhulenev @andyly I had some CLA issues in #39760 while I was fixing GPU failure. This PR is identical to old one except for the small fix to the GPU failure. Sorry for the inconvenience.

@gbaned gbaned self-assigned this Aug 18, 2020
@gbaned gbaned added the comp:grappler Grappler related issues label Aug 18, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 18, 2020
@gbaned gbaned requested a review from ezhulenev August 18, 2020 08:24
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 18, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 18, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 18, 2020
@tensorflow-copybara tensorflow-copybara merged commit 0155fd6 into tensorflow:master Aug 19, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 19, 2020
@mdfaijul mdfaijul deleted the amin/nchw-nhwc-grappler-part1 branch August 19, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:grappler Grappler related issues ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants