Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Minor fix on AutoGraph limitation doc #42494

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

kooyunmo
Copy link
Contributor

There needs a minor correction for the AutoGraph limitation example.

def MyClass(object):
  def change(self):
    self.y += 1

c = MyClass()
while x > 0:
  c.change()  # Problem -- modification to c.y is not visible here!

and

def MyClass(object):
  def change(self):
    self.y += 1
    return self

c = MyClass()
while x > 0:
  c = c.change()  # Okay -- c is now a loop var.

In these examples, def MyClass should be class MyClass

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Aug 19, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gbaned gbaned self-assigned this Aug 19, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 19, 2020
@gbaned
Copy link
Contributor

gbaned commented Aug 19, 2020

@kooyunmo Can you please sign CLA. Thanks!

@kooyunmo
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gbaned gbaned added the comp:autograph Autograph related issues label Aug 19, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 19, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 19, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 19, 2020
@tensorflow-copybara tensorflow-copybara merged commit 32b90cb into tensorflow:master Aug 19, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:autograph Autograph related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants