Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #42501

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Update CONTRIBUTING.md #42501

merged 1 commit into from
Aug 20, 2020

Conversation

Aniketks29
Copy link
Contributor

Fixed typos

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Aug 19, 2020
@rthadur rthadur self-requested a review August 20, 2020 02:01
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 20, 2020
@rthadur
Copy link
Contributor

rthadur commented Aug 20, 2020

cc @mihaimaruseac

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 20, 2020
@gbaned gbaned self-assigned this Aug 20, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 20, 2020
@tensorflow-copybara tensorflow-copybara merged commit 772923e into tensorflow:master Aug 20, 2020
PR Queue automation moved this from Assigned Reviewer to Merged Aug 20, 2020
mihaimaruseac
mihaimaruseac reviewed Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted

CONTRIBUTING.md
@@ -15,7 +15,7 @@ Before sending your pull requests, make sure you followed this list.

### Contributor License Agreements

We'd love to accept your patches! Before we can take them, we have to jump a couple of legal hurdles.
We'd love to accept your patches! Before we can take them, you have to jump a couple of legal hurdles.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is "we" as in Google

CONTRIBUTING.md
@@ -33,7 +33,7 @@ just getting started, Github has a
[how to](https://help.github.com/articles/using-pull-requests/).

TensorFlow team members will be assigned to review your pull requests. Once the
pull requests are approved and pass continuous integration checks, a TensorFlow
pull requests are approved and passes continuous integration checks, a TensorFlow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct form is "pass", since we're talking about multiple pull requests

@mihaimaruseac mihaimaruseac mentioned this pull request Aug 20, 2020
Closed
tensorflow-copybara pushed a commit that referenced this pull request Aug 20, 2020
@mihaimaruseac @tensorflower-gardener
PR #42501: Update CONTRIBUTING.md
7d1d373 
Close #42527

Imported from GitHub PR #42501

Fixed typos
Copybara import of the project:

--
0dd22ba by Aniket Kumar Singh <aniketks321@gmail.com>:

Update CONTRIBUTING.md

Fixed typos

PiperOrigin-RevId: 327694861
Change-Id: I1b26624ffa041a02ff3d7a88bb3cc4e02993b836
@rthadur
Copy link
Contributor

rthadur commented Aug 21, 2020

@mihaimaruseac thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac left review comments

@rthadur rthadur rthadur approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Aniketks29 @rthadur @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned