[MLIR] Add folder for mhlo get_dimension_size #42509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bondhugula
changed the title
bondhugula
changed the title
bondhugula
force-pushed
the
get_dimension_size_fold
branch
from
b70e0d9
to
d150a91
Compare
bondhugula
changed the title
bondhugula
force-pushed
the
get_dimension_size_fold
branch
from
d150a91
to
ae581ca
Compare
joker-eph
previously approved these changes
Aug 21, 2020
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
bondhugula
force-pushed
the
get_dimension_size_fold
branch
from
ae581ca
to
4969511
Compare
|
Fixed dialect name in test cases: xla_hlo -> mhlo |
joker-eph
previously approved these changes
Aug 21, 2020
google-ml-butler
bot
added
kokoro:force-run
|
@sherhut @joker-eph The internal builds here may fail here since a lot of ops would get folded away (since shapes are typically constant, and more operands would become constant with this folding). |
|
@bondhugula can you please fix ubuntu sanity build failures ? |
joker-eph
added
kokoro:force-run
|
Seems like in conflicts, can you rebase? |
Done. |
bondhugula
force-pushed
the
get_dimension_size_fold
branch
from
4969511
to
90fef6d
Compare
Add folder for mhlo GetDimensionSizeOp. get_dimension_size folds to a constant when the corresponding tensor dimension size is statically known / constant.
|
Rebased and fixed conflict. |
bondhugula
force-pushed
the
get_dimension_size_fold
branch
from
90fef6d
to
5994915
Compare
joker-eph
approved these changes
Aug 24, 2020
google-ml-butler
bot
added
kokoro:force-run
copybara-service bot
pushed a commit
to tensorflow/mlir-hlo
that referenced
this pull request
Aug 24, 2020
Imported from GitHub PR tensorflow/tensorflow#42509 Add folder for mhlo GetDimensionSizeOp (`mhlo.get_dimension_size`). `get_dimension_size` folds to a constant when the corresponding tensor dimension size is statically known / constant. Copybara import of the project: -- 5994915525ec2e932125aa1f133ce2260ba100af by Uday Bondhugula <uday@polymagelabs.com>: [MLIR] Add folder for mhlo get_dimension_size Add folder for mhlo GetDimensionSizeOp. get_dimension_size folds to a constant when the corresponding tensor dimension size is statically known / constant. COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#42509 from polymage-labs:get_dimension_size_fold 5994915525ec2e932125aa1f133ce2260ba100af PiperOrigin-RevId: 328222517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add folder for mhlo GetDimensionSizeOp (
mhlo.get_dimension_size).get_dimension_sizefolds to a constant when the corresponding tensordimension size is statically known / constant.