-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include jsonCPP headers via #include "json/json.h" #42516
Include jsonCPP headers via #include "json/json.h" #42516
Conversation
Don't use #include "include/json/json.h" which is unusual and therefore confusing This allows to remove the header symlinking done for the system lib version Closes tensorflow#42303
Thanks for doing this, the symlinking in jsoncpp systemlibs has annoyed me since the beginning. I made a PR some time ago ( #38327 ) but hit some test failures and was too busy to resolve the last ones. Again thanks so much for taking the time to work on this! |
Seems like the build worked. Seeing some strange errors on OSX related to Note: I have a similar PR open but for system nasm: #42266 Would be great if you can have a look or assign someone to take care of it. Change is trivial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's import and see if anything breaks.
Don't use #include "include/json/json.h" which is unusual and therefore confusing
This allows to remove the header symlinking done for the system lib version
Closes #42303
Disclaimer: I've tested the system build with this which works, not 100% sure about Bazel as I'm not very familiar with it but the
includes = ["include"],
in thecc_library
rule should mean this works.