Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF:MLIR] Add complex type reciprocal pattern to TF to TF lowerings #42532

Merged
merged 2 commits into from
Aug 24, 2020
Merged

[TF:MLIR] Add complex type reciprocal pattern to TF to TF lowerings #42532

merged 2 commits into from
Aug 24, 2020

Conversation

ahmedsabie
Copy link
Contributor

No description provided.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Aug 20, 2020
@ahmedsabie ahmedsabie changed the title Add complex type reciprocal pattern to TF to TF lowerings [TF:MLIR] Add complex type reciprocal pattern to TF to TF lowerings Aug 20, 2020
@gbaned gbaned self-assigned this Aug 21, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 21, 2020
smit-hinsu
smit-hinsu previously approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@smit-hinsu smit-hinsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Could you drop Reciprocal from the list of ops in this pass now that this pattern fully supports the Reciprocal op.
tensorflow/compiler/mlir/xla/transforms/legalize_tf_with_tf2xla.cc

tensorflow/compiler/mlir/tensorflow/transforms/lower_tf.td Show resolved Hide resolved
tensorflow/compiler/mlir/tensorflow/transforms/lower_tf.cc Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 21, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 21, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 21, 2020
@gbaned gbaned removed the ready to pull PR ready for merge process label Aug 21, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Aug 21, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 22, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 22, 2020
@tensorflow-copybara tensorflow-copybara merged commit c8c1982 into tensorflow:master Aug 24, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smit-hinsu smit-hinsu smit-hinsu approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ahmedsabie @smit-hinsu @googlebot @kokoro-team @tensorflow-copybara @gbaned