[INTEL MKL] Enable Conv + (Bias+BN) + LeakyRelu Fusion with Eigen implementation in CPU (Resubmit) #42551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retonym
changed the title
ezhulenev
approved these changes
Aug 21, 2020
google-ml-butler
bot
added
kokoro:force-run
rthadur
added
ready to pull
rthadur
approved these changes
Aug 21, 2020
google-ml-butler
bot
added
kokoro:force-run
retonym
changed the title
|
Hi Rajeshwar and Eugene, the UT failures are not related to this PR. Please help to approve this PR. |
ezhulenev
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error in #42489
This error is caused by not sending activation parameter with conv + bn + leakyrelu pattern in
remapper.cc4d022d6 is the squeeze commit for all commits in #42489
6aabcb1 updates the unit test to capture the error found in Google internal test.
62db9a7 fixes the error.