-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiling against system protobuf #42591
Fix compiling against system protobuf #42591
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@sclarkson Thank you for your contribution. Can you please sign CLA? Thanks! |
f350266
to
ab6c3bf
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@gbaned Had the wrong email address on the commit. Fixed it now. |
@sclarkson Thanks for that PR, ran into this too. @gbaned @mihaimaruseac Wouldn't it somehow possible for you guys to set up a CI job that tests building with those system libs? They break with every release and require painful patching for package managers. |
We could attempt supporting a community based build, I think, if someone from the open source maintains it. |
When trying to compile with the bazel configuration
build --action_env TF_SYSTEM_LIBS="com_google_protobuf"
, the following errors occur.This PR adds the missing protobuf library definitions to successfully compile against the system protobuf.