Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiling against system protobuf #42591

Merged

Conversation

sclarkson
Copy link
Contributor

When trying to compile with the bazel configuration build --action_env TF_SYSTEM_LIBS="com_google_protobuf", the following errors occur.

ERROR: /home/sclarkson/tensorflow-master/tensorflow/core/data/service/BUILD:31:17: no such target '@com_google_protobuf//:any_proto': target 'any_proto' not declared in package '' defined by /home/sclarkson/.cache/bazel/_bazel_sclarkson/fffe72c6b1157d70fb0a456ab7b675c2/external/com_google_protobuf/BUILD.bazel and referenced by '//tensorflow/core/data/service:dispatcher_proto'

This PR adds the missing protobuf library definitions to successfully compile against the system protobuf.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Aug 23, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gbaned gbaned self-assigned this Aug 23, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 23, 2020
@gbaned
Copy link
Contributor

gbaned commented Aug 23, 2020

@sclarkson Thank you for your contribution. Can you please sign CLA? Thanks!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@sclarkson
Copy link
Contributor Author

@gbaned Had the wrong email address on the commit. Fixed it now.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 24, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 24, 2020
@tensorflow-copybara tensorflow-copybara merged commit ee4387f into tensorflow:master Aug 25, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 25, 2020
@Flamefire
Copy link
Contributor

@sclarkson Thanks for that PR, ran into this too.

@gbaned @mihaimaruseac Wouldn't it somehow possible for you guys to set up a CI job that tests building with those system libs? They break with every release and require painful patching for package managers.

@mihaimaruseac
Copy link
Collaborator

We could attempt supporting a community based build, I think, if someone from the open source maintains it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants