mis-indent in conv_ops_test python scripts #42712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed code block was inside the for loop iterating over values from GetTestConfigs().
It make more sense to me to move these line out from the loop, so instead evaluating the unfinished expected_results & computed_values lists for multiple times, only a one time evaluation will be performed on them.
I am not quite sure whats the original purpose how it was writing this way, from my view, I would like to move them out, please correct me if I am wrong.
And a question, could there be a problem to evaluate these tensors over and over again?