Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mis-indent in conv_ops_test python scripts #42712

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

LeicongLi
Copy link
Contributor

The changed code block was inside the for loop iterating over values from GetTestConfigs().
It make more sense to me to move these line out from the loop, so instead evaluating the unfinished expected_results & computed_values lists for multiple times, only a one time evaluation will be performed on them.

I am not quite sure whats the original purpose how it was writing this way, from my view, I would like to move them out, please correct me if I am wrong.

And a question, could there be a problem to evaluate these tensors over and over again?

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Aug 27, 2020
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gbaned gbaned self-assigned this Aug 28, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 28, 2020
@gbaned gbaned requested a review from reedwm August 28, 2020 02:34
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 28, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 28, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 28, 2020
@reedwm
Copy link
Member

reedwm commented Aug 28, 2020

Good catch! I'm also not sure why it the entire list was originally computed inside the loop. I don't think problems would arise evaluating the tensors over and over again, but its slow and it's better not to.

It would probably be best to not even have a list and assert the two values are all close inside the for-loop but that can always be done later.

@tensorflow-copybara tensorflow-copybara merged commit 9c3e405 into tensorflow:master Aug 28, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants