TFLu: Fix Ethos-U build issue #42823
Conversation
The issue is that a binary need to be built twice, since it depends on recursive_find. The driver is not fully downloaded when recursive_find is called. The solution is to call the download script immediately via the make's shell function. Also add missing exit to error case in download script.
gbaned
added
comp:lite
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list: We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
|
I'll let @petewarden review this since he is most familiar with the Makefile logic and its repercussions. |
| @@ -1,19 +1,31 @@ | |||
| ifneq ($(filter ethos-u,$(ALL_TAGS)),) | |||
| # Don't want -lm flag | |||
| MICROLITE_LIBS := | |||
| MICROLITE_LIBS := $(filter-out -lm,$(MICROLITE_LIBS)) | |||
There was a problem hiding this comment.
Add short comment to why we filter out the -lm flag
There was a problem hiding this comment.
Seems like it is not longer needed, will remove it.
There was a problem hiding this comment.
@mansnils Any update on this PR? Please. Thanks!
There was a problem hiding this comment.
It might still be needed. So I am adding a comment. I think it more belong in a tools/make/target/makefile but there is none for this yet so let's keep it here for now.
There was a problem hiding this comment.
I meant, what happens if we use the -lm flag? What issue does it cause?
There was a problem hiding this comment.
Will #43726 make the filtering out here not be needed anymore? Let's get this PR merged since its been sitting for a long time but then circle back and have the exclusion in a single place.
There was a problem hiding this comment.
As long as the target in #43726 is used I guess the filtering out here is not needed anymore. As said let's revisit this later.
google-ml-butler
bot
added
kokoro:force-run
|
Looks good from my side. |
|
@petewarden Ping for review |
google-ml-butler
bot
added
kokoro:force-run
The issue is that a binary need to be built twice, since it
depends on recursive_find. The driver is not fully downloaded when
recursive_find is called.
The solution proposal is to call the download script
immediately via the make's shell function.
Also add missing exit to error case in download script.