Fix extraneous depecation message caused by setdiff1d #42935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
force-pushed
the
42909-setdiff1d-deprecation
branch
from
f243160
to
ee253ac
Compare
This PR tries to address the issue raised in 42909 where extraneous
deprecation messages showed up when with the following:
```
import tensorflow as tf
x = tf.ones(5)
with tf.GradientTape() as g:
g.watch(x)
y = tf.math.reduce_prod(x)
grad = g.gradient(y, x)
WARNING:tensorflow:From /usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/math_grad.py:300: setdiff1d (from tensorflow.python.ops.array_ops) is deprecated and will be removed after 2018-11-30.
Instructions for updating:
This op will be removed after the deprecation date. Please switch to tf.sets.difference().
```
The deprecation is misleading to users.
This PR switch to use internal `gen_array_ops.list_diff` so that
deprecation messages will not be triggered.
Several other places using setdiff1d have also been fixed.
This PR fixes 42909.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
yongtang
force-pushed
the
42909-setdiff1d-deprecation
branch
from
ee253ac
to
734ac4e
Compare
mdanatg
approved these changes
Sep 4, 2020
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issue raised in #42909 where extraneous
deprecation messages showed up when with the following:
The deprecation is misleading to users.
This PR switch to use internal
gen_array_ops.list_diffso thatdeprecation messages will not be triggered.
Several other places using setdiff1d have also been fixed.
This PR fixes #42909.
Signed-off-by: Yong Tang yong.tang.github@outlook.com