Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the optimization level in a variable. #42962

Merged

Conversation

jenselofsson
Copy link
Contributor

Makes it possible to manually specify the optimization used by the compiling by appending OPTIMIZATION_LEVEL=-Ofast (for example) when compiling with make.

Fixes #42924

Make it possible to specify the optimization level from the command
line and make it the same regardless of the BUILD_TYPE.
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Sep 4, 2020
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@jenselofsson
Copy link
Contributor Author

One thought I had immediately after submitting this pull request is if I should document this feature somewhere in a README?

@gbaned gbaned self-assigned this Sep 4, 2020
@gbaned gbaned added comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers labels Sep 4, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 4, 2020
@advaitjain
Copy link
Member

One thought I had immediately after submitting this pull request is if I should document this feature somewhere in a README?

Yeah, that would be nice. Unfortunately we don't have good organization for documenting the Makefiles at this time. We will be taking a pass at documentation once we make some changes to the framework.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Sep 8, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 8, 2020
@tensorflow-copybara tensorflow-copybara merged commit 9153548 into tensorflow:master Sep 8, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Sep 8, 2020
@jenselofsson jenselofsson deleted the manual_optimization branch September 9, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

TensorFlow Lite Micro: Make it possible to specify optimization level when building with the Makefile
6 participants