Add bazel to the test_x86 script. #43118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
njeffrie
previously approved these changes
Sep 10, 2020
google-ml-butler
bot
added
kokoro:force-run
njeffrie
previously approved these changes
Sep 10, 2020
google-ml-butler
bot
added
kokoro:force-run
This is because the bazel build is already part of the presubmits and the goal here is to enable developers to catch errors sooner locally. Also, the fact that the micro test_all.sh script runs within a docker container means that initiating a bazel build on the CI system would mean downloading bazel to the docker image.
njeffrie
approved these changes
Sep 11, 2020
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
comp:lite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable external contributors to more easily test with bazel and prevent back and forth to try and resolve internal errors.
Note that bazel is not invoked from test_all.sh. This is because the bazel build is already part of the presubmits and the goal here is to enable developers to catch errors sooner locally.
Also, the fact that the micro test_all.sh script runs within a docker container means that initiating a bazel build on the CI system would mean downloading bazel to the docker image.