Increase the number of targets that are built for Bluepill. #43160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help provide some safeguard against issues like tensorflow#43126 Note that the tests are only built, not run because we are currently unable to use renode as part of out continuous integration system. Also note that some of the core tests (such as micro_interpreter_test) do not build for the bluepill target and have been explicitly excluded. Finally, note that while the kernel_circular_buffer_test builds for bluepill, it does not pass and so had to be excluded.
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
njeffrie
previously approved these changes
Sep 11, 2020
| @@ -36,8 +32,8 @@ ENTRY(_main) | |||
|
|
|||
| /* 20K of RAM and 128K of FLASH */ | |||
| MEMORY { | |||
| RAM (xrw) : ORIGIN = 0x20000000, LENGTH = 20K | |||
| FLASH (rx) : ORIGIN = 0x8000000, LENGTH = 128K | |||
| RAM (xrw) : ORIGIN = 0x20000000, LENGTH = 256K | |||
There was a problem hiding this comment.
removed the unnecessary comment.
| EXCLUDED_TESTS := \ | ||
| tensorflow/lite/micro/micro_interpreter_test.cc \ | ||
| tensorflow/lite/micro/simple_tensor_allocator_test.cc | ||
| tensorflow/lite/micro/micro_allocator_test.cc \ |
There was a problem hiding this comment.
I assume these tests never worked for bluepill?
There was a problem hiding this comment.
not in the recent past. I have an internal bug to track this down.
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
comp:lite
njeffrie
approved these changes
Sep 12, 2020
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help provide some safeguard against issues like #43126
Note:
Manually tested that micro/tools/ci_build/test_bluepill.sh passes on my local machine (i.e. builds and all the tests that are run, pass).