Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTEL MKL] Added missed bfloat16 CPU support for op math.rsqrt #43167

Merged
merged 1 commit into from Sep 14, 2020
Merged

[INTEL MKL] Added missed bfloat16 CPU support for op math.rsqrt #43167

merged 1 commit into from Sep 14, 2020

Conversation

cuixiaom
Copy link
Contributor

No description provided.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Sep 12, 2020
@gbaned gbaned self-assigned this Sep 12, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 12, 2020
@gbaned gbaned added the comp:mkl MKL related issues label Sep 12, 2020
penpornk
penpornk approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Sep 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 14, 2020
@tensorflow-copybara tensorflow-copybara merged commit 735c020 into tensorflow:master Sep 14, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Sep 14, 2020
tensorflow-copybara pushed a commit that referenced this pull request Sep 17, 2020
@tensorflower-gardener
PR #43167: [INTEL MKL] Added missed bfloat16 CPU support for op math.…
5d80f59 
…rsqrt

Imported from GitHub PR #43167

Copybara import of the project:

--
17ca1c7 by Xiaoming (Jason) Cui <xiaoming.cui@intel.com>:

[INTEL MKL] Added missed  bfloat16 CPU support for op math.rsqrt

PiperOrigin-RevId: 332304599
Change-Id: I9c66d29ed7cf1010388d70f30f84fef97de6dde6
@cuixiaom
Copy link
Contributor Author

This PR has been merged, and I can see the merge information in the log, but the files doesn't have the changes in this PR, was there a merge issue? please check the file in the master:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/kernels/cwise_op_rsqrt.cc
which doesn't have the changes from this PR, but in the history of this file, I can see there is merge record.

@penpornk
Copy link
Member

@cuixiaom It got rolled back because it broke some of our internal tests that cannot be easily fixed. I'll try to bring it back but it might take some time. Sorry about that!

@cuixiaom
Copy link
Contributor Author

@penpornk thanks for your response! Please let me know if need my help.

@cuixiaom cuixiaom mentioned this pull request May 21, 2021
Merged
copybara-service bot pushed a commit that referenced this pull request May 27, 2021
@tensorflower-gardener
PR #49286: [INTEL MKL] re-submit rsqrst op bfloat16 support
f3bfe37 
Imported from GitHub PR #49286

the reverted PR is here:
#43167
Copybara import of the project:

--
b5b6fd1 by Xiaoming (Jason) Cui <xiaoming.cui@intel.com>:

[INTEL MKL] re-submit rsqrst op bfloat16 support

PiperOrigin-RevId: 376118079
Change-Id: Ic0abb40246d028310aac334e4db2f5b92d93717f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:mkl MKL related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cuixiaom @penpornk @googlebot @kokoro-team @tensorflow-copybara @gbaned