Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gcs partial reponse and absl strcat #43191

Merged
merged 1 commit into from Sep 14, 2020
Merged

Use gcs partial reponse and absl strcat #43191

merged 1 commit into from Sep 14, 2020

Conversation

vnghia
Copy link
Contributor

@vnghia vnghia commented Sep 13, 2020

  • Most of the time, we only need a small portion of gcs response ( usually size ). I add gcs::Fields to fetch only the fields we need from gcs server. This technique is called partial response and it allows us to increase performance.

  • I mixed between absl::StrCat and std::string concatenation. This time, I change everything to absl::StrCat.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Sep 13, 2020
@gbaned gbaned self-assigned this Sep 14, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 14, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Sep 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 14, 2020
@tensorflow-copybara tensorflow-copybara merged commit 2e5b478 into tensorflow:master Sep 14, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vnghia @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned