Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r1.15 Eigen download link is dead #43348

Closed
ghost opened this issue Sep 18, 2020 · 6 comments
Closed

r1.15 Eigen download link is dead #43348

ghost opened this issue Sep 18, 2020 · 6 comments
Assignees
Labels
comp:lite TF Lite related issues TF 1.15 for issues seen on TF 1.15 type:build/install Build and install issues

Comments

@ghost
Copy link

ghost commented Sep 18, 2020

version r1.15

The download link for Eigen is dead (https://bitbucket.org/eigen/eigen/get/49177915a14a.tar.gz)

This patch switches the link to use the google storage bucket

From 765a2b04268d030d247a45d600686f3bac5e5d38 Mon Sep 17 00:00:00 2001
From: Chris Roed <chris.roed@omcare.com>
Date: Tue, 1 Sep 2020 11:36:49 -0500
Subject: [PATCH 3/3] use the google repo for eigen

---
 tensorflow/lite/tools/make/download_dependencies.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tensorflow/lite/tools/make/download_dependencies.sh b/tensorflow/lite/tools/make/download_dependencies.sh
index ef4a7777e6..678e35d987 100755
--- a/tensorflow/lite/tools/make/download_dependencies.sh
+++ b/tensorflow/lite/tools/make/download_dependencies.sh
@@ -29,7 +29,7 @@ if [ ! -f $BZL_FILE_PATH ]; then
   exit 1;
 fi
 
-EIGEN_URL="$(grep -o 'http.*bitbucket.org/eigen/eigen/get/.*tar\.gz' "${BZL_FILE_PATH}" | grep -v mirror.tensorflow | head -n1)"
+EIGEN_URL="$(grep -o 'http.*bitbucket.org/eigen/eigen/get/.*tar\.gz' "${BZL_FILE_PATH}" | grep mirror.tensorflow | head -n1)"
 GEMMLOWP_URL="$(grep -o 'https://storage.googleapis.com/mirror.tensorflow.org/github.com/google/gemmlowp/.*zip' "${BZL_FILE_PATH}" | head -n1)"
 GOOGLETEST_URL="https://github.com/google/googletest/archive/release-1.8.0.tar.gz"
 ABSL_URL="$(grep -o 'https://github.com/abseil/abseil-cpp/.*tar.gz' "${BZL_FILE_PATH}" | head -n1)"
-- 
2.20.1

@ghost ghost added the type:build/install Build and install issues label Sep 18, 2020
@bhack
Copy link
Contributor

bhack commented Sep 19, 2020

I don't know on what TF version you are but on master the download URL is ok.

@amahendrakar amahendrakar added comp:lite TF Lite related issues TF 1.15 for issues seen on TF 1.15 labels Sep 21, 2020
@amahendrakar amahendrakar assigned ymodak and unassigned amahendrakar Sep 21, 2020
@jdduke
Copy link
Member

jdduke commented Sep 23, 2020

There's nothing we can do for 1.15. Can you upgrade to the latest release version of TFLite (2.3)? Alternatively, we're working on a CMake-based build system for the upcoming 2.4 release.

@jdduke jdduke closed this as completed Sep 23, 2020
@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@jdduke
Copy link
Member

jdduke commented Sep 23, 2020

That said, if we end up doing some kind of patched release for 1.15, we can keep this in mind (and feel free to create a PR with your patch), but until then the branch is effectively frozen.

@ghost
Copy link
Author

ghost commented Sep 23, 2020

Sounds good. I'm stuck on 1.15 for now, but hopefully anyone else running into the issue is able to find this :-)

@mihaimaruseac
Copy link
Collaborator

It's too late now, but we are planning some patch releases to come out today/tomorrow.

If you can make a PR to update, on the next patch releases it will be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:lite TF Lite related issues TF 1.15 for issues seen on TF 1.15 type:build/install Build and install issues
Projects
None yet
Development

No branches or pull requests

5 participants