Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transform to fuse activations into TFL pooling ops #43482

Merged
merged 1 commit into from Oct 14, 2020
Merged

Add transform to fuse activations into TFL pooling ops #43482

merged 1 commit into from Oct 14, 2020

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Sep 23, 2020

TFLite average and max pool operations support fused activation functions similar to the convolution ops. This PR adds a MLIR transform to the TFLite converter to fuse activations functions into preceding pooling operations.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Sep 23, 2020
@gbaned gbaned self-assigned this Sep 23, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 23, 2020
@gbaned gbaned added the awaiting review Pull request awaiting review label Sep 25, 2020
@gbaned gbaned requested a review from smit-hinsu October 6, 2020 16:05
@smit-hinsu smit-hinsu requested review from abattery and removed request for smit-hinsu October 6, 2020 19:19
@lgeiger
Copy link
Contributor Author

lgeiger commented Oct 13, 2020

@joker-eph @abattery do you mind giving this PR a quick review?

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 13, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 13, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 14, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 14, 2020
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 14, 2020
@lgeiger
Copy link
Contributor Author

lgeiger commented Oct 14, 2020

@abattery Thanks for approving the PR!

Would you also be able to take a look at #41790 which is a crutial bug fix for #39572 and touches similar files?

@copybara-service copybara-service bot merged commit 76960fe into tensorflow:master Oct 14, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Oct 14, 2020
@lgeiger lgeiger deleted the tflite-fuse-pool-act branch October 14, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abattery abattery abattery approved these changes

@gbaned gbaned gbaned approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lgeiger @abattery @gbaned @googlebot @kokoro-team @rthadur