[tf.data server] prevent restart of the dispatcher server w/o fault-tolerance, in the test bed #43714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaudiber
requested changes
Oct 2, 2020
| """Stops `dispatcher` and creates a new dispatcher with the same port.""" | ||
| """Stops `dispatcher` and creates a new dispatcher with the same port. | ||
|
|
||
| When the dispatcher is restarted with `fault-tolerant_mode=False`, |
There was a problem hiding this comment.
This scenario is too specific, can we make the docstring more general, e.g. "Restarting is only supported when the dispatcher is configured with fault_tolerant_mode=True"?
|
Made the change, @aaudiber. |
aaudiber
approved these changes
Oct 2, 2020
google-ml-butler
bot
added
kokoro:force-run
|
@aaudiber, I had a quick question regarding the updates to the workers based on the task list. How would we identify whether the task list changed or not if we don't poll for changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #43691 and prevents a restart of the dispatcher if it has been configured without fault-tolerance. Failing to do so will lead to a perpetual stream of
warnmessages on a dispatcher restart and unnecessarily extend the testing time without an immediate exit.@aaudiber until the enhancements are implemented to handle such scenarios (as per our discussion), this will help us in handling the upcoming test cases.