[XLA/GPU] clear operands for removed HLOs. #43746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids possible accesses to the Null operands.
|
@thomasjoerg, the change ran through NV's internal CI tests well. Please help to take a look and let's see if it can also run through your CIs well. |
|
@thomasjoerg |
thomasjoerg
approved these changes
Oct 7, 2020
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids possible accesses to the Null operands.
Operands of a removed instruction is not cleared but only set to NULL. A more sound behavior should be to also clear the operands for the removed instructions, so that we avoid potential accesses to the NULL operands.
This fixed a crash case encountered by #43051.