Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coreml delegate] fix usage of coremltools header #43837

Merged
merged 2 commits into from Nov 7, 2020
Merged

[coreml delegate] fix usage of coremltools header #43837

merged 2 commits into from Nov 7, 2020

Conversation

freedomtan
Copy link
Contributor

  1. including "external/...." will cause problems when using tensorflow
    as a third party / external package
  2. there are some redundant includes

@freedomtan
[coreml delegate] fix usage of coremltools header
7a30000 
1. including "external/...." will cause problems when using tensorflow
   as a third party / external package
2. there are some redundant includes
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Oct 7, 2020
@google-cla google-cla bot added the cla: yes label Oct 7, 2020
@gbaned gbaned self-assigned this Oct 7, 2020
@gbaned gbaned added the comp:lite TF Lite related issues label Oct 7, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 7, 2020
@gbaned gbaned requested a review from daverim October 7, 2020 07:16
@gbaned gbaned added the awaiting review Pull request awaiting review label Oct 13, 2020
@multiverse-tf multiverse-tf requested review from teijeong and removed request for daverim November 4, 2020 08:05
@teijeong
Copy link
Contributor

teijeong commented Nov 5, 2020

Thanks for the fix! deletions looks good, but renames require internal toolchain change. Let me fix that part first, and please update this PR after that.

teijeong
teijeong approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@teijeong teijeong left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved some conflicts. Thanks!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Nov 6, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 6, 2020
@gbaned gbaned removed the awaiting review Pull request awaiting review label Nov 6, 2020
@copybara-service copybara-service bot merged commit 73272ab into tensorflow:master Nov 7, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teijeong teijeong teijeong approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freedomtan @teijeong @kokoro-team @gbaned