Refactor SparseApplyFtrl CPU kernel into class #43868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is in preparation for adding a GPU implementation.
google-ml-butler
bot
added
kokoro:force-run
sanjoy
suggested changes
Oct 11, 2020
|
Description edited to describe NFC. |
sanjoy
suggested changes
Oct 14, 2020
Comment on lines
2823
to
2827
| OP_REQUIRES( | ||
| ctx, bad_i < 0, | ||
| errors::InvalidArgument( | ||
| "indices", SliceDebugString(indices.shape(), bad_i), " = ", | ||
| indices_vec(bad_i), " is not in [0, ", var.dim_size(0), ")")); |
There was a problem hiding this comment.
IMO making this non local is harder to understand. Can you have operatior() return a Status (OK or InvalidArgument) and use OP_REQUIRES_OK here?
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for adding a GPU implementation.
(This is the second split of #43299).
cc @nluehr @sanjoy
Edit: This PR makes no functional change except for the indexing error message (which is changed to match that of SparseApplyKerasMomentumOp which has the same code structure).