Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing motivation for TF hacking in Pix2Pix Generative tutorial #43929

Open
Antymon opened this issue Oct 10, 2020 · 3 comments
Open

Missing motivation for TF hacking in Pix2Pix Generative tutorial #43929

Antymon opened this issue Oct 10, 2020 · 3 comments
Assignees
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:docs-feature Doc issues for new feature, or clarifications about functionality

Comments

@Antymon
Copy link

Antymon commented Oct 10, 2020

URL(s) with the issue:

Please provide a link to the documentation entry, for example:
The note from
https://www.tensorflow.org/tutorials/generative/pix2pix#generate_images

Description of issue (what needs changing):

Under the section pointed to above there is a note addressing a hack in the code where training mode is used for a piece of code serving as "visual validation". To me, as a person learning from this tutorial, it is insufficient. Although it mitigates the uncertainty around unexpected measures by saying that this is done for the sake of certain shapes of statistics, it also cuts abruptly by saying "and this is what we [don't] want". This leaves me puzzled with why do we want such thing, the more so that further on we take just a single sample which means that the batch norm degenerates to instance norm.

Clear description

Can someone please add motivation to why training statistics are preferred in this case and perhaps relate to the issue of BN in the case of a single example?

@ravikyram ravikyram added the type:docs-bug Document issues label Oct 12, 2020
@ravikyram ravikyram assigned ymodak and unassigned ravikyram Oct 12, 2020
@ymodak ymodak added type:docs-feature Doc issues for new feature, or clarifications about functionality and removed type:docs-bug Document issues labels Oct 12, 2020
@ymodak ymodak assigned yashk2810 and unassigned ymodak Oct 12, 2020
@yashk2810
Copy link
Member

See section 3.3 in the paper: https://arxiv.org/pdf/1611.07004.pdf

@rmothukuru rmothukuru self-assigned this Feb 26, 2021
@rmothukuru rmothukuru added the stat:awaiting response Status - Awaiting response from author label Feb 26, 2021
@rmothukuru
Copy link
Contributor

@Antymon,
Can you please respond to the above comment? Thanks!

@Antymon
Copy link
Author

Antymon commented Feb 26, 2021

@Antymon,
Can you please respond to the above comment? Thanks!

Sure! Thank you for the reference @yashk2810, that does shed some light indeed!

@rmothukuru As for the issue - I haven't noticed any change in the tutorial contents, or have I missed something? If you want to help just me that's fine, but if you want to enlighten more people perhaps you would like to revisit the contents I have referred to above.

Thank you!

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Feb 28, 2021
@rmothukuru rmothukuru removed their assignment Mar 2, 2021
@rmothukuru rmothukuru added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:docs-feature Doc issues for new feature, or clarifications about functionality
Projects
None yet
Development

No branches or pull requests

6 participants