Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change description of drop_remainder argument of Dataset method window #44027

Merged
merged 1 commit into from Oct 20, 2020
Merged

Change description of drop_remainder argument of Dataset method window #44027

merged 1 commit into from Oct 20, 2020

Conversation

ibeauregard
Copy link
Contributor

In general, several windows are dropped when drop_remainder is set to True.

@ibeauregard
Change description of drop_remainder argument of Dataset method window
0157b76 
In general, several windows are dropped when drop_remainder is set to True.
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 14, 2020
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@gbaned gbaned self-assigned this Oct 15, 2020
@gbaned gbaned added the comp:data tf.data related issues label Oct 15, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 15, 2020
@gbaned gbaned requested a review from aaudiber October 15, 2020 02:31
@gbaned gbaned added the awaiting review Pull request awaiting review label Oct 16, 2020
aaudiber
aaudiber approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@aaudiber aaudiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 19, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 19, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 19, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 20, 2020
@copybara-service copybara-service bot merged commit 101df48 into tensorflow:master Oct 20, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaudiber aaudiber aaudiber approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:data tf.data related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ibeauregard @aaudiber @kokoro-team @gbaned