Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 instructions from TF Lite demo README #44101

Merged
merged 1 commit into from Oct 30, 2020

Conversation

TylerADavis
Copy link
Contributor

@TylerADavis TylerADavis commented Oct 16, 2020

Python 2 is not supported in TensorFlow after TF 2.1, so having Python 2 instructions in a demo's README in 2.4.0 is misleading.

Python 2 is not supported in TensorFlow after 2.1, so Python 2 instructions in README are misleading
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 16, 2020
@google-cla
Copy link

google-cla bot commented Oct 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 16, 2020
@TylerADavis
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 16, 2020
@gbaned gbaned self-assigned this Oct 17, 2020
@gbaned gbaned added the comp:lite TF Lite related issues label Oct 17, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 17, 2020
@gbaned gbaned requested a review from terryheo October 17, 2020 03:46
@gbaned gbaned added the awaiting review Pull request awaiting review label Oct 27, 2020
Copy link
Member

@terryheo terryheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 29, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 29, 2020
@gbaned gbaned removed the awaiting review Pull request awaiting review label Oct 29, 2020
@copybara-service copybara-service bot merged commit 02b4da0 into tensorflow:master Oct 30, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants