Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that when hdfsBuilderConnect returns NULL, HadoopFileSystem::FileExists returns errors::NotFound exception #44190

Merged
merged 1 commit into from Oct 23, 2020
Merged

Fix that when hdfsBuilderConnect returns NULL, HadoopFileSystem::FileExists returns errors::NotFound exception #44190

merged 1 commit into from Oct 23, 2020

Conversation

yuanbopeng
Copy link
Contributor

Fix that when hdfsBuilderConnect returns NULL, HadoopFileSystem::Connect returns errors::NotFound, which conflicts with errors::NotFound in HadoopFileSystem::FileExists. errors::NotFound means that the file does not exist

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 21, 2020
@google-cla google-cla bot added the cla: yes label Oct 21, 2020
@yuanbopeng
Copy link
Contributor Author

/cc @jhseu @mihaimaruseac @vnvo2409

@gbaned gbaned self-assigned this Oct 21, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 21, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 22, 2020
@mihaimaruseac mihaimaruseac removed the ready to pull PR ready for merge process label Oct 22, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 22, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 22, 2020
@mihaimaruseac
Copy link
Collaborator

@53jk1 please don't approve PRs where you don't have approval rights and was not asked for approval.

@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 23, 2020
@copybara-service copybara-service bot merged commit 7bd0d8f into tensorflow:master Oct 23, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Oct 23, 2020
@yuanbopeng yuanbopeng deleted the patch-fix branch October 23, 2020 17:16
@yuanbopeng
Copy link
Contributor Author

@mihaimaruseac thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbakdev kbakdev kbakdev approved these changes

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yuanbopeng @mihaimaruseac @kbakdev @kokoro-team @gbaned