Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in lite directory #44415

Merged
merged 3 commits into from Nov 11, 2020
Merged

Fix typos in lite directory #44415

merged 3 commits into from Nov 11, 2020

Conversation

Molkree
Copy link
Contributor

@Molkree Molkree commented Oct 29, 2020

Splitting #43857 by top-level directories.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Oct 29, 2020
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@google-cla google-cla bot added the cla: yes label Oct 29, 2020
@gbaned gbaned self-assigned this Oct 29, 2020
@gbaned gbaned added the comp:lite TF Lite related issues label Oct 29, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 29, 2020
@gbaned gbaned requested a review from lintian06 October 29, 2020 04:07
@lintian06 lintian06 added the ready to pull PR ready for merge process label Nov 2, 2020
@lintian06
Copy link
Contributor

Hi Dmitry,

Can you revert changes in tensorflow/lite/delegates/gpu/cl/kernels/conv_constants.cc and conv_constants.h as it causes conflict? Thank you!

@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Nov 2, 2020
@Molkree
Copy link
Contributor Author

Molkree commented Nov 2, 2020

@lintian06, only tensorflow/lite/delegates/gpu/cl/kernels/conv_constants.cc was causing conflict, I resolved it.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Nov 2, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 2, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 2, 2020
@copybara-service copybara-service bot merged commit 229a8af into tensorflow:master Nov 11, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Nov 11, 2020
@Molkree Molkree deleted the typos_in_lite_dir branch November 11, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lintian06 lintian06 Awaiting requested review from lintian06

Assignees

@gbaned gbaned

Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Molkree @lintian06 @mihaimaruseac @kokoro-team @gbaned